Fix persistent local flag in session url updating #13905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short-lived regression from 5ce9687. I forgot to add the persistent local flag, so that means that RC_DEBUG will complain. These strings are local to the thread so we can just add the flag to silence the debug checker in this case.
nielsdos
added a commit
that referenced
this pull request
Apr 7, 2024
* PHP-8.2: Fix persistent local flag in session url updating (#13905)
nielsdos
added a commit
that referenced
this pull request
Apr 7, 2024
* PHP-8.3: Fix persistent local flag in session url updating (#13905)
bwoebi
pushed a commit
to bwoebi/php-src
that referenced
this pull request
Apr 7, 2024
Short-lived regression from 5ce9687. I forgot to add the persistent local flag, so that means that RC_DEBUG will complain. These strings are local to the thread so we can just add the flag to silence the debug checker in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-lived regression from 5ce9687. I forgot to add the persistent local flag, so that means that RC_DEBUG will complain. These strings are local to the thread so we can just add the flag to silence the debug checker in this case.
This fixes the nightly failure in ext-session.